1. Forum
  2. FidoNet
  3. SYNC PROGRAMMING

  • src/sbbs3/chat.cpp

    From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Wednesday, March 02, 2022 18:14:50
    https://gitlab.synchro.net/main/sbbs/-/commit/92cb63183d0178719e95b75a
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    Fix CID 33252: Argument cannot be negative
    --- SBBSecho 3.15-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Thursday, October 20, 2022 20:43:32
    https://gitlab.synchro.net/main/sbbs/-/commit/9229bef09f652b69825a98d9
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    Add error and debug level log messages to private chatWhen reading and writing characters to chat files, log each with a debug-levellog message. If a read or a write fails, log with an error-level log message.This will hopefully help root-cause and resolve issue #304.
    --- SBBSecho 3.15-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Thursday, October 20, 2022 20:57:43
    https://gitlab.synchro.net/main/sbbs/-/commit/1f04cc14152bc4312d490061
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    Don't log debug msgs when reading 0 (\x00) from chat.dab file, expectedThis just resulted in a lot of unhelpful noise in the log output
    --- SBBSecho 3.15-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Friday, October 21, 2022 12:10:19
    https://gitlab.synchro.net/main/sbbs/-/commit/1cdc4d8d590b1fa1a3506bee
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    Fix-up the recently-added debug/error log messagesI didn't look closely enough at which write() call I was instrumenting.This is now more useful, though I think we already found the root-causebased on different log output ("Unexpected ansi_getxy response").
    --- SBBSecho 3.15-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows)@1:103/705 to Git commit to main/sbbs/master on Thursday, February 02, 2023 13:48:41
    https://gitlab.synchro.net/main/sbbs/-/commit/b56bf8edcf92494e56d410aa
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    Sysop can chat with nodes that aren't logged-in (at logon prompt, new users)Be sure to let them select a node even when no nodes are technically "in use".As requested by Nelgin in IRC (what, no gitlab issue?)
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows)@1:103/705 to Git commit to main/sbbs/master on Monday, April 17, 2023 11:38:40
    https://gitlab.synchro.net/main/sbbs/-/commit/44f626bbcd42e03864c73def
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    Add source node number to sysop notification that they're being paged to chatFix issue #551
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows)@1:103/705 to Git commit to main/sbbs/master on Friday, April 28, 2023 23:58:45
    https://gitlab.synchro.net/main/sbbs/-/commit/62e2280e6e59c520eae9abb4
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    Fix buffer overflow in guru chat parsing engineThe trigger was this line in the recent change to guru.dat:Unrealized potential. :-(That open paren was parsed as the beginning of a new guru expression. A verylong guru expression that overflowed the stack variable 'str' here.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on ChromeOS)@1:103/705 to Git commit to main/sbbs/master on Sunday, April 30, 2023 15:20:17
    https://gitlab.synchro.net/main/sbbs/-/commit/5fd4f1ca4a66fa612d243c0b
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    A close-parenthesis in a guru.dat response string would throw-off the parserAfter a negative-match of a Guru expression, we were searching for the next'(' anywhere in the subsequent chars of the file rather than just the nextline that started with an open-parenthesis character.This bug was the secondary cause of the buffer-overflow crash addresseed incommit 62e2280e which was triggered by my recent updates to the guru.dat.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Saturday, March 23, 2024 17:19:53
    https://gitlab.synchro.net/main/sbbs/-/commit/39934b3b272b55412a3e211c
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    Fix CID 33725: Use after close
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Monday, April 22, 2024 23:13:05
    https://gitlab.synchro.net/main/sbbs/-/commit/750bea33377fd220b013db96
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    Don't allow sysops to page or send messages to nodes without a useron

    Fix a long standing bug where by sysops could page for chat or send node messages or telegrams to any node, even if there wasn't a user even connected.

    Regular users were not affected by this bug.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)