1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/ftpsrvr.cpp

    From Deuc¿@VERT to Git commit to main/sbbs/master on Sunday, February 22, 2026 10:33:30
    https://gitlab.synchro.net/main/sbbs/-/commit/b795545afa5e0cc6250e0fb2
    Modified Files:
    src/sbbs3/ftpsrvr.cpp
    Log Message:
    This is C++ now, value-initialize since we can't zero-initialize

    Same-same, but different, but still same.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Saturday, May 02, 2026 18:58:15
    https://gitlab.synchro.net/main/sbbs/-/commit/f28f210b217239031baa9af1
    Modified Files:
    src/sbbs3/ftpsrvr.cpp
    Log Message:
    sbbs3 ftpsrvr: modernize legacy BOOL/TRUE/FALSE to bool/true/false

    Mechanical conversion across the file: function signatures, local
    variables (incl. volatile flags shared across xfer threads), xfer_t
    struct fields, and all literal arguments/comparisons. External callees (load_cfg, matchuser, getnodedat, wildmatchi, seteuid callback) already
    declare bool parameters, so no ABI change. Also collapse direxist()'s
    if/else to a single return.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Tuesday, May 05, 2026 15:55:25
    https://gitlab.synchro.net/main/sbbs/-/commit/8a7ff359a230d7820816acb5
    Modified Files:
    src/sbbs3/ftpsrvr.cpp
    Log Message:
    Use int (32-bits) instead of bool (8-bits) for setsockopt(... REUSEADDR)

    Fix issue #1137 (bug introduced in commit f28f210b)

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Tuesday, May 05, 2026 15:56:57
    https://gitlab.synchro.net/main/sbbs/-/commit/f1f4ac3fce5a360a4f2446ed
    Modified Files:
    src/sbbs3/ftpsrvr.cpp
    Log Message:
    Use int (32-bit) instead of bool (8-bit) for setsockopt(... NODELAY)

    Similar to fix for issue #1137

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wednesday, May 06, 2026 22:36:57
    https://gitlab.synchro.net/main/sbbs/-/commit/769599ebba788f26253334f3
    Modified Files:
    src/sbbs3/ftpsrvr.cpp
    Log Message:
    ftpsrvr: handle return values in send/receive_thread and sock_recvbyte (CIDs 643130, 643142, 643143)

    - send_thread/receive_thread: log a warning if fseeko to xfer.filepos
    fails so a seek error is no longer silent (downstream I/O would
    proceed at the wrong offset). Continues into the transfer loop
    either way to preserve existing behavior.
    - sock_recvbyte: cast the inner cryptSetAttribute (re-arming the read
    timeout) to void; this is best-effort and the matching call above
    it is already error-checked.

    Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net