https://gitlab.synchro.net/main/sbbs/-/commit/b1bb5630000e4065a9377f1b
Modified Files:
src/sbbs3/userdat.c
Log Message:
Handle filelength() possibly returning negative valueCID 349724
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/d43068225eab3fd62b66f1b2
Modified Files:
src/sbbs3/userdat.c
Log Message:
Address Coverity-scan reported issuesCould use more long->off_t conversions, but this is a start.
--- SBBSecho 3.15-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/169c6dcc8956ff86294071d7
Modified Files:
src/sbbs3/userdat.c
Log Message:
Added NULL argument checking
--- SBBSecho 3.15-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/40eec7fa665daee9c365e43f
Modified Files:
src/sbbs3/userdat.c
Log Message:
Posts from QWKnet users don't count as "posts" for local statsMight add some other statistic for these relayed posts at some point.
--- SBBSecho 3.15-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/14940b8a7f261cb137b69035
Modified Files:
src/sbbs3/userdat.c
Log Message:
Fix possible underflow conditions in gettimeleft()If a non-'T' exempt user had already used more time today than their security level allows, their timeleft would be computed as a negative value due to integer underflow. Since the return value of this function is assigned to a ulong (timeleft), this becomes a large positive number. Cap the floor of the computed time left at 0.Also fix the potential for underflow that could occur if the system clock changes while a user is online and 'now' becomes greater than 'starttime'.
--- SBBSecho 3.15-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/8ad5e191568032ec2d91c79f
Modified Files:
src/sbbs3/userdat.c
Log Message:
matchuser() now always returns 0 when passed an empty 'name'Also, don't match against deleted (blank) usernames in name.dat(e.g. when 'name' value consists of a single ETX character).
--- SBBSecho 3.15-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/6c0e423a38920f64abfb7013
Modified Files:
src/sbbs3/userdat.c
Log Message:
Don't truncate a user's record if the default download protocol or gender are '\0'A blank download protocol field in a user.dat, when parsed, sets the 'prot' fieldof user_t to 0. When writing the record back to the user.dat, this would prematurelytruncate all other fields off the user record (since strings in C are NUL terminatedand we're using sprintf() to format the record and %c specifier for that field).The fix is to write a ' ' character instead of '\0' if the user_t.prot is '\0'.As part of this fix, I'm writing a '?' if a user_t.sex is '\0' (not sure if thisis actually possible, but just as insurance). Those are the only 2 single-characteruser properties/fields today.Bug reported/debugged by Al of The Rusty Mailbox (1:153/757.2) - thank you!
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/14125aa4b0aa0bf027f77361
Modified Files:
src/sbbs3/userdat.c
Log Message:
The NoAccess* text.dat strings are not appropriate 'reason' codesThese text.dat strings require an argument (and normally used with the NOACCESS @-code which uses the noaccess_str and noaccess_val member variables), so not appropriate to use as a reason code here. Use more generic (no argument) text.dat item numbers instead.
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/edc931be6282acafdf043532
Modified Files:
src/sbbs3/userdat.c
Log Message:
More strict login-by-user-number support (parsing logic)Before now, if the sysop enabled login-by-user-number and the specified loginID *started* with a decimal digit, it'd be treated as a user number andconverted to a 32-bit integer. This could result in weird stuff, like thiserror I got today:SMTP ... !ERROR -2 getting data on user (7000401005.gc7gg@synchro.net)7,000,401,005 is clearly greater than the number of users in my user baseon Vert, but since 7B is > 2.1B (0x7fffffff), the number would be parsed asa *negative* integer value and thus less than the total number of users in myuserbase.An obvious solution would be to just turn of login-by-user-number, and formost systems, I suggest doing that (a system is less secure with it enabled).However, I want to leave the option for sysops (at least for now) and don'twant this weird behavior so, a login by user number now requires that theentire login ID is just decimal numbers, nothing else, and the number isparsed as an unsigned integer. So yes, roll-over can happen for very highnumbers (>4.2B), but in no instance will the number be parsed as negative andthus lead to an invalid user record look-up attempt.
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/e0979e270d947bc8a9e64e70
Modified Files:
src/sbbs3/userdat.c
Log Message:
Fix GCC 9.4.0 warning reported by Nelginwarning: format not a string literal and no format argumentsWeird this warning is happening for me with GCC 12.2 (debug or release build)
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/c1d6e2c764781b0400578600
Modified Files:
src/sbbs3/userdat.c
Log Message:
The "user" directory is special: you don't need "access" to download from it.When sending a user-to-user file transfer, SBBS (since v3.19) will check thatthe file recipient will be able to download it (e.g. doesn't have restrictionspreventing it) and this was failing for most (non-sysop) recipient users sincethey wouldn't normally meet the "access restrictions" of the user directory(by design).
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 userdat.c 1.214 1.215
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv23153

Modified Files:
userdat.c
Log Message:
delfiles() now takes a 3rd argument: keep, which is a number of files to retain (not delete) from the end of the sorted list of files (normally, 0).

--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/68d9c3265f981c3579115177
Modified Files:
src/sbbs3/userdat.c
Log Message:
Truncate attempted user-name at '@' before comparing against name.can file

'@' is in the name.can by default and the mail server recognizes user@addr formatted logins/attempts, so truncate at the '@' before comparing against
the name.can file to prevent false !TEMPORARY BAN (1 login attempts, ... occurences.
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/39b718dd3ea96ef9f70b5575
Modified Files:
src/sbbs3/userdat.c
Log Message:
Fix typos in comments
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/e675cd6612c6723d40063f44
Modified Files:
src/sbbs3/userdat.c
Log Message:
Fix bug with parse_birthdate() in year-first format

The year is 4 digits, so the offsets aren't the same as the other 2 supported formats. Doh!

Thanks Max for testing!
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/3bf7380f569eababc753e3fc
Modified Files:
src/sbbs3/userdat.c
Log Message:
nodestatus() print internal code rather than xtrn number, if possible

(as a fall back to the full external program name).
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/d6293e05bccdff9ff8fbb1c8
Modified Files:
src/sbbs3/userdat.c
Log Message:
Fix logic to add the "partially" prefix to download notification messages

The file_t struct may not have the size of the file pre-poulated, so we needed to call getfilesize() here.
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)